Resolve deprecation warnings related to datetime.utcnow in python 3.12#335
Open
brouberol wants to merge 2 commits intompdavis:masterfrom
Open
Resolve deprecation warnings related to datetime.utcnow in python 3.12#335brouberol wants to merge 2 commits intompdavis:masterfrom
brouberol wants to merge 2 commits intompdavis:masterfrom
Conversation
Closed
Jamim
suggested changes
Dec 27, 2023
Jamim
left a comment
Jamim
left a comment
There was a problem hiding this comment.
Hello @brouberol,
Thank you for taking care of that warning!
I'd like to suggest a way to simplify your changes a bit.
Co-authored-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
Author
|
Thanks @Jamim! Good call indeed |
Jamim
approved these changes
Dec 27, 2023
|
will this be bundled into release 3.4 or just a minor update? |
|
Hello @phifuh,
Sorry, but it looks like chances of this happening are near zero. Best regards! |
|
@Jamim thats fair, eventually someone might fork this project and actively maintain it, at least thats what I hope |
|
guess it makes more sense to migrate to https://github.com/jpadilla/pyjwt |
This was referenced Jan 17, 2025
Collaborator
|
fixed in #372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading my project to python 3.12, I started seeing deprecation warnings related to the use of
datetime.datetime.utcnow.This PR simply implements the suggestion (in a backwards-compatible fashion), to get rid of these warnings in all projects depending on
python-jose.Regards
Fixes #334